src/app/main.py (1)

136-138: Pylint W0621 (app shadowing outer scope) — acceptable for ASGI middleware constructors.

The app parameter in __init__ shadows the module-level app (the FastAPI instance). This is the standard ASGI middleware constructor signature and suppressing the warning is fine. The R0903 "too few public methods" warnings are also inherent to the ASGI middleware pattern. Consider adding a # pylint: disable=... inline or a project-level pylint config entry if you want a clean lint run.

Also applies to: 182-184

tests/unit/app/test_main_middleware.py (3)

30-52: _ResponseCollector is a handy test utility.

The pipeline flags missing docstrings on status_code and body_json properties (C0116). Since these are test-internal helpers the impact is minimal, but adding one-liners would silence the linter.

---

110-112: Prefix unused ASGI parameters with _ to silence W0613.

The pipeline flags scope, receive, and send as unused in the inner test apps. Prefixing with _ is the standard Python convention and would clean up the lint output.

Example for one of the inner apps

-    async def partial_response_app(scope: Scope, receive: Receive, send: Send) -> None:
+    async def partial_response_app(_scope: Scope, _receive: Receive, send: Send) -> None:

Apply the same pattern to inner_app in both non-HTTP tests (unused scope, receive, send).

Also applies to: 126-128, 145-147

---

140-151: RestApiMetricsMiddleware has only one test — consider adding coverage for the happy path and edge cases.

The only test verifies non-HTTP passthrough. The following scenarios are untested at the unit level:

1. Metrics counter increment — a request to a known app route results in rest_api_calls_total being incremented with the correct path and status.
2. /metrics endpoint exclusion — requests ending with /metrics do not increment the counter.
3. Non-app-route passthrough — a path not in app_routes_paths bypasses metrics entirely.
4. Status code capture — send_wrapper correctly extracts the status from http.response.start.

These are the core behaviors of the middleware and are worth covering, especially since the class was just rewritten.

tests/unit/app/test_main_middleware.py (1)

40-45: Add docstrings to the status_code and body_json properties.

The linter flags C0116: Missing function or method docstring on these properties. As per coding guidelines, "All functions require docstrings with brief descriptions and complete type annotations for parameters and return types".

Proposed fix

     `@property`
     def status_code(self) -> int:
+        """Return the HTTP status code from the collected response messages."""
         for msg in self.messages:
             if msg["type"] == "http.response.start":
                 return msg["status"]
         raise AssertionError("No http.response.start message")
 
     `@property`
     def body_json(self) -> dict:
+        """Return the response body decoded as JSON."""
         body = b""